-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add file extensions to all files #830
fix: Add file extensions to all files #830
Conversation
36264a9
to
7298fef
Compare
can we delete |
c2d67da
to
63f7a5f
Compare
Yes, but another PR, so we don't hide such removals within other changes (easier to restore or track them if needed) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix shell or disable broken file in this PR and fix in following PR.
🎉 All dependencies have been resolved ! |
63f7a5f
to
7d4237c
Compare
/lgtm |
New changes are detected. LGTM label has been removed. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
c76ef1e
to
d814af0
Compare
Signed-off-by: Mateus Oliveira msouzaol@redhat.com
Describe the behavior changes introduced in this PR
Add file extensions to all files. This enable the quality tools to check all of them.
We can add them to makefile or console scripts to avoid calling them with the extension.
Linked Issues
resolves #684
depends on #944
Testing Instructions
I have run
find . -type f ! -name "?*.*" | grep -v "venv/\|git/\|.pytest_cache/\|htmlcov/"
to check for files without extension (there is still one that I think should have, that is./pelorus-operator/PROJECT
, but it is generated by script, so we need to change script to change it).To check if I have changed all needed places of invocation of the file, I have run
grep -Iinr 'name_of_the_file' . --exclude-dir={.venv,htmlcov,.pytest_cache,.mypy_cache}
.