Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add file extensions to all files #830

Merged

Conversation

mateusoliveira43
Copy link
Collaborator

@mateusoliveira43 mateusoliveira43 commented Jan 30, 2023

Signed-off-by: Mateus Oliveira msouzaol@redhat.com

Describe the behavior changes introduced in this PR

Add file extensions to all files. This enable the quality tools to check all of them.

We can add them to makefile or console scripts to avoid calling them with the extension.

Linked Issues

resolves #684
depends on #944

Testing Instructions

I have run find . -type f ! -name "?*.*" | grep -v "venv/\|git/\|.pytest_cache/\|htmlcov/" to check for files without extension (there is still one that I think should have, that is ./pelorus-operator/PROJECT, but it is generated by script, so we need to change script to change it).

To check if I have changed all needed places of invocation of the file, I have run grep -Iinr 'name_of_the_file' . --exclude-dir={.venv,htmlcov,.pytest_cache,.mypy_cache}.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
@mateusoliveira43 mateusoliveira43 self-assigned this Feb 7, 2023
@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 8, 2023
@mateusoliveira43
Copy link
Collaborator Author

can we delete demo/deprecrated/demo.sh file?

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 2, 2023
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 14, 2023
@mpryc
Copy link
Collaborator

mpryc commented Apr 18, 2023

can we delete demo/deprecrated/demo.sh file?

Yes, but another PR, so we don't hide such removals within other changes (easier to restore or track them if needed)

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023
Copy link
Collaborator

@mpryc mpryc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix shell or disable broken file in this PR and fix in following PR.

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023
@dpulls
Copy link

dpulls bot commented Apr 18, 2023

🎉 All dependencies have been resolved !

mpryc
mpryc previously approved these changes Apr 19, 2023
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023
@mpryc
Copy link
Collaborator

mpryc commented Apr 19, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Apr 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 19, 2023

New changes are detected. LGTM label has been removed.

@openshift-ci
Copy link

openshift-ci bot commented Apr 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mateusoliveira43. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 19, 2023
@openshift-ci
Copy link

openshift-ci bot commented Apr 19, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from mateusoliveira43. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mateusoliveira43
Copy link
Collaborator Author

/retest

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mateusoliveira43 mateusoliveira43 merged commit 2441922 into dora-metrics:master Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File extensions
4 participants