Long term storage for #23 [WIP] #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themoosman
reviewed
May 28, 2020
| To retain Pelorus dashboard data in the long-term, we'll deploy an instance of [minio](https://github.com/helm/charts/tree/master/stable/minio) and create a bucket called `thanos`. | ||
|
|
||
| ``` | ||
| helm install --set "buckets[0].name=thanos" \ |
There was a problem hiding this comment.
This assumes that you have a helm repo configured. You many need to run helm repo add stable https://kubernetes-charts.storage.googleapis.com
There was a problem hiding this comment.
What namespace should this deploy into? Currently, it just uses the existing namespace.
themoosman
approved these changes
Jun 3, 2020
|
This LGTM as I can see data being pushed to MinIO. However, I'm not able to pull the data back out. Merging this code and will open a bug for the other issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for someone to test the steps for installing long term storage. I did overwrite our installation instructions to assume that people will be using minio.
Future work will provide options to change the bucket types to S3, GCS, etc