Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mockoon script failing silently #766

Merged
merged 5 commits into from
Jan 13, 2023

Conversation

mateusoliveira43
Copy link
Collaborator

Signed-off-by: Mateus Oliveira msouzaol@redhat.com

Describe the behavior changes introduced in this PR

Remove the behavior of silently fail from the mockoon script.

Linked Issues

No.

Testing Instructions

Check CI logs for the mockoon job and run make mockoon-tests locally.

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jan 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign mpryc for approval by writing /assign @mpryc in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mpryc
Copy link
Collaborator

mpryc commented Jan 5, 2023

@mateusoliveira43 what is the delete_me.txt file for?

@mateusoliveira43
Copy link
Collaborator Author

@mateusoliveira43 what is the delete_me.txt file for?

Just to trigger the CI heheheeh I was planning to ask Kevin to delete it in his PR, but now thinking, I believe is better to change the job yaml file to also trigger when there is changes to the mockoon script. What you think?

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mateusoliveira43
Copy link
Collaborator Author

@KevinMGranger can you check if this ok so we can review your mockoon PR?

@openshift-ci
Copy link

openshift-ci bot commented Jan 12, 2023

@mateusoliveira43: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.9-e2e-openshift ee5c8aa link false /test 4.9-e2e-openshift
ci/prow/4.8-e2e-openshift ee5c8aa link false /test 4.8-e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mpryc
Copy link
Collaborator

mpryc commented Jan 13, 2023

This works, however there is small issue which can be addressed in separate PR.

Running the make mockoon-tests without prior running make dev-env will cause the mockoon tests to fail.

@mpryc
Copy link
Collaborator

mpryc commented Jan 13, 2023

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2023
@mpryc mpryc merged commit 43f0162 into dora-metrics:master Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-signoff: yes lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants