-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mockoon script failing silently #766
fix: mockoon script failing silently #766
Conversation
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mateusoliveira43 what is the delete_me.txt file for? |
Just to trigger the CI heheheeh I was planning to ask Kevin to delete it in his PR, but now thinking, I believe is better to change the job yaml file to also trigger when there is changes to the mockoon script. What you think? |
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@KevinMGranger can you check if this ok so we can review your mockoon PR? |
@mateusoliveira43: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This works, however there is small issue which can be addressed in separate PR. Running the |
/lgtm |
Signed-off-by: Mateus Oliveira msouzaol@redhat.com
Describe the behavior changes introduced in this PR
Remove the behavior of silently fail from the mockoon script.
Linked Issues
No.
Testing Instructions
Check CI logs for the mockoon job and run
make mockoon-tests
locally.