Fix pelorus operator script to add proper instructions and remove dup #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As found by @mateusoliveira43 there was duplication of logic in our Pelorus operator script to echo versions. Fixed as well instructions that includes new bundle method. Signed-off-by: Michal Pryc <mpryc@redhat.com>
mpryc
force-pushed
the
duplicated_shell
branch
from
29feaf8 to
4b4e031
Compare
mateusoliveira43
approved these changes
Dec 16, 2022
|
After deploying pelorus.. exporters end up w/ value {} and the defaults are deployed :( |
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
@weshayutin I think you put hold on wrong PR, one should be #750, however it's now fixed as well. |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
operator-sdk run bundle quay.io/migtools/pelorus-operator-bundle:v0.0.38 --namespace pelorus works for me.. |
weshayutin
approved these changes
Dec 16, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As found by @mateusoliveira43 there was duplication of logic in our Pelorus operator script to echo versions.
Fixed as well instructions that includes new bundle method.
Signed-off-by: Michal Pryc mpryc@redhat.com
@redhat-cop/mdt