Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed icon for the pelorus-operator #737

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

mpryc
Copy link
Collaborator

@mpryc mpryc commented Nov 29, 2022

Fixes #736 where the white icon was on a transparent background.

Signed-off-by: Michal Pryc mpryc@redhat.com

Testing Instructions

Install operator.

Screenshot of an pelorus-operator with fixed icon (installed from my own image registry, but built with this PR)

Screenshot from 2022-11-29 15-10-32

@redhat-cop/mdt

Fixes dora-metrics#736 where the white icon was on a transparent background.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 29, 2022
@openshift-ci
Copy link

openshift-ci bot commented Nov 29, 2022

@mpryc: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/4.8-e2e-openshift 7ba5cee link false /test 4.8-e2e-openshift
ci/prow/4.11-e2e-openshift 7ba5cee link false /test 4.11-e2e-openshift

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mpryc
Copy link
Collaborator Author

mpryc commented Nov 29, 2022

/retest

@openshift-ci
Copy link

openshift-ci bot commented Nov 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinMGranger, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [KevinMGranger,weshayutin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KevinMGranger
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 29, 2022
@KevinMGranger KevinMGranger merged commit 64de9e4 into dora-metrics:master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon for the pelorus-operator should be changed
3 participants