Deserialization framework #726
Merged
+1,047
−65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hooting script Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
openshift-ci
bot
added
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
KevinMGranger
force-pushed
the
deserialization_framework
branch
from
ecf2b30 to
cd6a338
Compare
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
KevinMGranger
force-pushed
the
deserialization_framework
branch
from
cd6a338 to
85001c7
Compare
openshift-ci
bot
removed
the
do-not-merge/work-in-progress
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
KevinMGranger
force-pushed
the
deserialization_framework
branch
from
85001c7 to
7605679
Compare
|
/retest |
|
Also files |
|
/hold until documentation is added, renamed functions, and proper tests for dicts/lists |
openshift-ci
bot
added
the
do-not-merge/hold
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/lgtm Thanks for the work and great explanation in docs. |
mpryc
approved these changes
Nov 28, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates out the deserialization framework used to support #720.