Introduce the start of automatic type checking #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're not running it as part of pre-commit yet so we don't get error fatigue. Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
…dation Signed-off-by: Kevin M Granger <kgranger@redhat.com>
We're going to make the check itself not required for merging. Signed-off-by: Kevin M Granger <kgranger@redhat.com>
mpryc
previously approved these changes
Nov 8, 2022
openshift-ci
bot
added
the
approved
…d ignore error in gh action Signed-off-by: Kevin M Granger <kgranger@redhat.com>
openshift-ci
bot
removed
the
approved
|
/retest |
mpryc
reviewed
Nov 10, 2022
mpryc
approved these changes
Nov 10, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
KevinMGranger
added a commit
to KevinMGranger/pelorus
that referenced
this pull request
Nov 22, 2022
* Introduce the start of automatic type checking. We're not running it as part of pre-commit yet so we don't get error fatigue. Signed-off-by: Kevin M Granger <kgranger@redhat.com> * Fix node package name in github workflow Signed-off-by: Kevin M Granger <kgranger@redhat.com> * Update setup action versions for typecheck gh action; use caching Signed-off-by: Kevin M Granger <kgranger@redhat.com> * fix makefile for type checking, change apt to apt-get as per recommendation Signed-off-by: Kevin M Granger <kgranger@redhat.com> * Make type checking failure an error. We're going to make the check itself not required for merging. Signed-off-by: Kevin M Granger <kgranger@redhat.com> * add warning to make target, mark gh action as not quite ready yet, and ignore error in gh action Signed-off-by: Kevin M Granger <kgranger@redhat.com> Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're not running it as part of pre-commit yet so we don't get error fatigue.
Unfortunately, it doesn't seem like there's an easy way to mark a check as a "warning": actions/runner#2347. Never mind! We can just mark the check as not required for merging.Describe the behavior changes introduced in this PR
Adds a type check target and runs type checking in CI.
Type checking is not a hard requirement, and is just informational right now.
Linked Issues?
related to actions/toolkit#708
Testing Instructions
See CI logs.
To run it yourself, update your venv, make sure you have node installed on your system, and run
pyright.If you use VS Code and the python extension, you're probably already using pyright!