-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create cleaner social cards for link sharing #695
Conversation
/hold broken on macos |
Signed-off-by: Eric Sauer <esauer@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com> Signed-off-by: Eric Sauer <esauer@redhat.com>
Signed-off-by: Eric Sauer <esauer@redhat.com>
Signed-off-by: Eric Sauer <esauer@redhat.com>
Signed-off-by: Eric Sauer <esauer@redhat.com>
Signed-off-by: Eric Sauer <esauer@redhat.com>
The social cards aren't currently being served as expected. Opened a RTD issue to get some input: readthedocs/readthedocs.org#9680 |
/hold until RTD issue is addressed |
Got a response back on that issue. They pointed out that the link to those images that gets generated assumes a base domain that matches exactly what we enter in the I commented back to see if there's any config change that will allow that URL to be dynamically replaced during PR builds, but short of that, it sounds like we have to merge to find out if it worked. |
I got a comment back saying that there's currently not a way to make the build URLs dynamically replace our site URL, but that it may be comein in the future via some environment variable enhancements being discussed. With that, and considering that, by default our docs site point to the latest release, and not actually |
@etsauer could we define an environment variable for |
@KevinMGranger I looked into that, but since we don't control the hosting environment, we don't have access at the point where that would need to be set. That environment variable would already have to exist (which it doesn't) and then we could tap into it. |
@etsauer Ah, I misunderstood the issue on the RTD side. Darn. Guess we can just take it on faith that they're generated, or do something to check locally? |
@KevinMGranger we can already verify that the images are being generated. Let's take the index page in this PR build as an example: https://pelorus--695.org.readthedocs.build/en/695/ If you inspect the source and look in the And you try to open the link there you'll get a 404: https://pelorus.readthedocs.io/en/latest/assets/images/social/index.png HOWEVER, if you replace the base URL of https://pelorus.readthedocs.io/en/latest/ with the PR base URL of https://pelorus--695.org.readthedocs.build/en/695/, you'll see the image pop up: https://pelorus--695.org.readthedocs.build/en/695/assets/images/social/index.png So everything is working right, except the |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinMGranger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Eric Sauer esauer@redhat.com
Describe the behavior changes introduced in this PR
When we changed to the material theme doe the docs site, it changed the logo image we use, which doesn't look nice when we share links to the pelorus site. The social cards feature from Material fixes that: https://squidfunk.github.io/mkdocs-material/setup/setting-up-social-cards/#built-in-social-plugin
Testing Instructions
Please include any additional commands or pointers in addition to our standard PR testing process.
@redhat-cop/mdt