Allow to use EPOCH timestamp in the image annotation

[mpryc]

For the images that were build without commit time or hash data we allow to annotate them for the Commit Time exporter to work properly. This change allows to annotate with EPOCH time format.

Signed-off-by: Michal Pryc mpryc@redhat.com

@redhat-cop/mdt

[KevinMGranger]

I'm still confused by the epoch function, but I might be misremembering what we wanted.

I think we said:

• assume it's an epoch
• assume a long epoch string means it's in milliseconds

If we're allowing 13-digit epochs, that means it's in milliseconds, or it refers to the year 33658 at the earliest. Which will cause an exception from fromtimestamp:

proof of concept

In [6]: len("1" + "0" * 12)
Out[6]: 13

In [7]: to_epoch_from_string("1" + "0" * 12)
---------------------------------------------------------------------------
ValueError                                Traceback (most recent call last)
Cell In [7], line 1
----> 1 to_epoch_from_string("1" + "0" * 12)

File ~/workcode/pelorus/exporters/pelorus/timeutil.py:82, in to_epoch_from_string(timestring, allowed_length)
     78     raise ValueError(
     79         f"Tried to get epoch from not allowed string length: {timestring} / {allowed_length}"
     80     )
     81 else:
---> 82     return datetime.fromtimestamp(int(epoch_date_time))

ValueError: year 33658 is out of range

I also really don't get why customizing the number of digits is necessary. Where to do use any other values than the defaults?

Finally, there's one gotcha: it needs to be fromtimestamp(timestamp, timezone.utc), otherwise we get a naive datetime again. Those are really annoying. We should have a unit test to catch that. Disregard, I misunderstood the docs!

[KevinMGranger]

/hold timezone issue and milliseconds discussion

[KevinMGranger]

/unhold

[weshayutin]

/LGTM

[weshayutin]

[weshayutin]

/LGTM

[KevinMGranger]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: KevinMGranger, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [KevinMGranger,weshayutin]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mpryc]

/retest

[mpryc]

/test 4.11-e2e-openshift