Adds continous metric to the deploytime #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpryc
force-pushed
the
deployment_active_deployments
branch
from
d2d99e7 to
ecb02c7
Compare
|
We're inheriting the mistake the previous code made-- I'll have a proposed patch to clean that up in a second. |
|
Thoughts? KevinMGranger@1dec37a Compare: https://gist.github.com/KevinMGranger/78bf9c10becd8d7ad9b5fe267626a68c Not only are the metric readings now side-by-side, the statistics about python garbage collection differ by an order of magnitude. Do you accept these changes? |
Change that adds to the deploytime continous time series for the active deployments. Deployment with a timestamp creates an event, which may be in the past. Having just an event we are unable to make calculations based on the currently active deployments, because one may be gone from the cluster. Adding deployment_active metric to already existing deploy_timestamp will allow to better visualize Lead Time for Change, where the "dots" are connected to each other, plus in the future we may be able to answer additional questions such as how many deployed apps are still working. On top of that this change ensures one metric is presented only one time in the series rather then multiple times. The metrics were gathered several times multiplied by the number of found unique deployments. Signed-off-by: Michal Pryc <mpryc@redhat.com> Clean up deploytime - Simplifies reporting deploy_timestamp and deployment_active - Simplifies DeployTimeMetric creation (datetime handling) Signed-off-by: Kevin M Granger <kgranger@redhat.com> Co-authored-by: Kevin M Granger <kgranger@redhat.com>
KevinMGranger
force-pushed
the
deployment_active_deployments
branch
from
04bc399 to
02855f7
Compare
|
/hold |
openshift-ci
bot
added
the
do-not-merge/hold
|
not required for MVR.. let's so a follow up 2.0.1 |
mpryc
force-pushed
the
deployment_active_deployments
branch
from
02855f7 to
1dec37a
Compare
openshift-merge-robot
added
the
needs-rebase
KevinMGranger
force-pushed
the
deployment_active_deployments
branch
from
1dec37a to
02855f7
Compare
openshift-merge-robot
removed
the
needs-rebase
|
/retest |
1 similar comment
|
/retest |
|
Looks like a prow / AWS error, right? |
|
@KevinMGranger yeah |
|
/test 4.9-e2e-openshift |
KevinMGranger
approved these changes
Sep 26, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: KevinMGranger The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change that adds to the deploytime continous time series for the active deployments.
Deployment with a timestamp creates an event, which may be in the past. Having just an event we are unable to make calculations based on the currently active deployments, because one may be gone from the cluster.
Adding deployment_active metric to already existing deploy_timestamp will allow to better visualize Lead Time for Change, where the "dots" are connected to each other, plus in the future we may be able to answer additional questions such as how many deployed apps are still working.
On top of that this change ensures one metric is presented only one time in the series rather then multiple times. The metrics were gathered several times multiplied by the number of found unique deployments.
Fixes #657
Signed-off-by: Michal Pryc mpryc@redhat.com
@redhat-cop/mdt