Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some testing guidance and a PR template with a reference to it. #147

Merged
merged 3 commits into from
Jul 24, 2020
Merged

Add some testing guidance and a PR template with a reference to it. #147

merged 3 commits into from
Jul 24, 2020

Conversation

etsauer
Copy link
Collaborator

@etsauer etsauer commented Jul 23, 2020 •
edited
Loading

@redhat-cop/mdt

resolves #109

@themoosman themoosman self-assigned this Jul 23, 2020
@themoosman
Copy link
Collaborator

@etsauer This might just be how it renders, but the PR template seems to be missing references to resolves and related to
https://github.com/etsauer/mdt-quickstart/blob/pr-testing-guidance/.github/pull_request_template.md

themoosman
themoosman approved these changes Jul 24, 2020
View reviewed changes
Copy link
Collaborator

@themoosman themoosman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@themoosman themoosman merged commit 261556f into dora-metrics:master Jul 24, 2020
@etsauer etsauer deleted the pr-testing-guidance branch July 24, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@themoosman themoosman themoosman approved these changes

Assignees

@themoosman themoosman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document a standard testing procedure for PRs
2 participants
@etsauer @themoosman