-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: docs preview job #1133
fix: docs preview job #1133
Conversation
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
🎉 All dependencies have been resolved ! |
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
d3edcb8
to
32e2bca
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
@mateusoliveira43: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Linked Issues
depends on #1130Description
Fix documentation preview job.
Also fix
Makefile
patch file, that would createMakefile.orig
file.How changes were made
Updated documentation package, by running
poetry update mkdocs-material --with=doc # manually update packages in pyproject.toml poetry lock --no-update make update-requirements
Recreated
Makefile
patch file, runningcd pelorus-operator && diff -ruN ./Makefile.orig ./Makefile
.And finally run
./scripts/update_projects_version.py -f -r
to update project version.Testing Instructions
Check if related documentation generation commands work properly.