-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use Containerfile instead s2i #1004
fix: Use Containerfile instead s2i #1004
Conversation
Skipping CI for Draft Pull Request. |
72bbe28
to
5f228b5
Compare
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
/hold |
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
5c8bc79
to
fe722b4
Compare
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
/unhold |
Test images available! 🧪🚀 To test operator with them, run
To clean up environment afterwards, run
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Linked Issues
related to #862
Description
Use Containerfile instead of s2i to create exporters images.
Testing Instructions
Test in OpenShift
Create Pelorus instance with
using operator created by CI commented in this PR.
Check the logs from exporter build Pod and run
skopeo --help
in the terminal of running exporter Pod.Tests with E2E
Check if e2e tests used Containerfile to create images.
For example, run
./scripts/run-pelorus-e2e-tests.sh -o konveyor
and check the logs from exporters build Pod and runskopeo --help
in the terminal of running exporters Pod.After PR closes
Check if CI of following PRs work as expected: