Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Websocket connection TLS #43 #47

Closed
wants to merge 4 commits into from

Conversation

ImmanuelSegol
Copy link
Collaborator

There is a problem that arouses from the code generated from .proto files.
They contain new Buffer() which is deprecated in Node v10, and therefore throws an annoying warning:

[DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.

Is there a way to polyfill this?
Or perhaps another workaround?
I was looking at Porting to the Buffer.from()/Buffer.alloc() API this article but didn't really know the best route.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@ImmanuelSegol
Copy link
Collaborator Author

@michael1011 BTW sorry for not making this a feature branch in the dopetart/walli-server, I just ran into some problems I will pm you.

@michael1011
Copy link
Collaborator

@ImmanuelSegol take a look at this XUD issue for more information about the Node v10 Buffer problem.

@ImmanuelSegol
Copy link
Collaborator Author

ImmanuelSegol commented Sep 19, 2018

@michael1011 I think we should just wait for a new release like they are doing XUD issue.
I think we should merge #47 and open an issue(#48 ) so we won't forget to look out for a grpc-tools .

@ImmanuelSegol ImmanuelSegol deleted the upgrade_node branch September 28, 2018 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants