Falsy truthy and fix doov function #37
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
==========================================
+ Coverage 99.84% 99.84% +<.01%
==========================================
Files 47 47
Lines 1277 1285 +8
Branches 166 166
==========================================
+ Hits 1275 1283 +8
Partials 2 2
Continue to review full report at Codecov.
|
ozangunalp
requested changes
Dec 18, 2019
src/doov.ts
Outdated
| @@ -167,7 +167,8 @@ export function sum(...values: NumberFunction[]): NumberFunction { | |||
| return new NumberFunction(new NaryMetadata(values.map(value => value.metadata), SUM), (obj, ctx) => { | |||
| return values.reduce((previous, value) => { | |||
| const v = value.get(obj, ctx); | |||
| return v != null ? previous + v : previous; | |||
| // @ts-ignore : Here we are sure that v is neither null or undefined since Boolean(v) would return false. Furthermore, previous + 0 <=> previous. | |||
There was a problem hiding this comment.
Replace that with not null && not undefined ? previous + v : previous
src/doov.ts
Outdated
| @@ -158,7 +158,7 @@ export function count(...values: BooleanFunction[]): NumberFunction { | |||
| return new NumberFunction(new NaryMetadata(values.map(value => value.metadata), COUNT), (obj, ctx) => { | |||
| return values.filter(value => { | |||
| const v = value.get(obj, ctx); | |||
| return v != null ? v : false; | |||
| return Boolean(v) || false; | |||
src/doov.ts
Outdated
| @@ -149,7 +149,7 @@ export function matchNone(...values: BooleanFunction[]): BooleanFunction { | |||
| return new BooleanFunction(new NaryMetadata(values.map(value => value.metadata), NONE_MATCH), (obj, ctx) => { | |||
| return values.every(value => { | |||
| const v = value.get(obj, ctx); | |||
| return v != null ? !v : false; | |||
| return !v || false; | |||
ozangunalp
requested changes
Dec 18, 2019
src/dsl/lang/BooleanFunction.ts
Outdated
| public isTruthy(): BooleanFunction { | ||
| return new BooleanFunction( | ||
| new UnaryMetadata(this.metadata, IS_TRUTHY), | ||
| condition(this, false, (_: boolean) => true, false) |
There was a problem hiding this comment.
(expr: boolean) => Boolean(expr), false)
| public isFalsy(): BooleanFunction { | ||
| return new BooleanFunction( | ||
| new UnaryMetadata(this.metadata, IS_FALSY), | ||
| condition(this, false, (expr: boolean) => !Boolean(expr), true) |
tretail
force-pushed
the
falsy_truthy_and_fix_doov_function
branch
from
9678886 to
15767df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Porter un point d'attention particulier sur les modifs dans doov.ts ; on est bien d'accord que les BooleanFunction retournent toutes un boolean ?