overwriting namespace of purescript-record #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@doolse ping |
|
Sorry @athanclark for being so tardy, do you think you could base your pull request on purescript-record itself? That's what was discussed in #1, when you've done that we won't need this repo anymore. |
athanclark
added a commit
to athanclark/purescript-record
that referenced
this pull request
Sep 2, 2017
|
No prob! I just submitted it |
|
Is there anything else needed in this PR? With this PR and small modifications on purescript-reactnative this doolse/purescript-reactnative#14 is taken care of... currently I'm using @athanclark's fork for prescript-records with my fork of purescript-reactnative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there! I'm not sure if you knew or not, but paf31 already has a data-oriented perspective of records, and has also already obtained the
Data.Recordmodule namespace - https://pursuit.purescript.org/packages/purescript-record/0.1.0/docs/Data.RecordThis pull request just puts everything you've made in
Data.Record.Class- I believe it makes more sense this way. What do you think?