Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arabic Translation Done #638

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Conversation

xx7Ahmed7xx
Copy link

Review the Contributing Guidelines

Before submitting a pull request, verify it meets all requirements in the Contributing Guidelines.

Translations

See the Contributing Guidelines. Verify you've:

  • Tagged the language maintainer
  • Prefixed the title with a language code
    • Example: "ja: Fix ..."

@xx7Ahmed7xx
Copy link
Author

I have remade the arabic translation from start to finish, including the images that needs translation, Also More work will be added but it is in a usable state.

@xx7Ahmed7xx
Copy link
Author

@donnemartin hello can you accept the merge and make me active maintainer ?

Copy link

@Ahmad-alsanie Ahmad-alsanie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ahmed
I've added a review.
@donnemartin Arabic has a variety of dialects. However, the standard Arabic dialect is common and understandable across all Arab regions. I recommend the document to be translated into standard Arabic. A side from that, I noticed that many CS and industry related slangs are usually translated incorrectly either due to the lack of equivalent one word match or due to translator preferences; This could be solved by simply using the English slang as is or adding an Arabic sentence to translate the slang. The proposed PR above looks fine and understandable in term of translation but might contain some unnecessary changes (images, formats and vs dir) aside from minor language mistakes, this could be a good starting point for a localized ar content.

.vs/VSWorkspaceState.json Outdated Show resolved Hide resolved
.vs/ProjectSettings.json Outdated Show resolved Hide resolved
.vs/system-design-primer/project-colors.json Outdated Show resolved Hide resolved
README-ar.md Outdated Show resolved Hide resolved
README-ar.md Outdated Show resolved Hide resolved
* [التوافر بالأرقام](#availability-in-numbers)
* [نظام اسم المجال](#domain-name-system)
* [شبكة توصيل المحتوى](#content-delivery-network)
* [دفع CDNs](#push-cdns)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

شبكات توصيل المحتوى

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

اعتقد الأفضل كأصل الترجمة وعند شرح شيء شرحه منفصلًا قبل دمجه

README-ar.md Outdated Show resolved Hide resolved
README-ar.md Outdated Show resolved Hide resolved
README-ar.md Outdated Show resolved Hide resolved
@@ -1,4 +1,4 @@
*[English](README.md) ∙ [日本語](README-ja.md) ∙ [简体中文](README-zh-Hans.md) ∙ [繁體中文](README-zh-TW.md) | [العَرَبِيَّة‎](https://github.com/donnemartin/system-design-primer/issues/170) ∙ [বাংলা](https://github.com/donnemartin/system-design-primer/issues/220) ∙ [Português do Brasil](https://github.com/donnemartin/system-design-primer/issues/40) ∙ [Deutsch](https://github.com/donnemartin/system-design-primer/issues/186) ∙ [ελληνικά](https://github.com/donnemartin/system-design-primer/issues/130) ∙ [עברית](https://github.com/donnemartin/system-design-primer/issues/272) ∙ [Italiano](https://github.com/donnemartin/system-design-primer/issues/104) ∙ [한국어](https://github.com/donnemartin/system-design-primer/issues/102) ∙ [فارسی](https://github.com/donnemartin/system-design-primer/issues/110) ∙ [Polski](https://github.com/donnemartin/system-design-primer/issues/68) ∙ [русский язык](https://github.com/donnemartin/system-design-primer/issues/87) ∙ [Español](https://github.com/donnemartin/system-design-primer/issues/136) ∙ [ภาษาไทย](https://github.com/donnemartin/system-design-primer/issues/187) ∙ [Türkçe](https://github.com/donnemartin/system-design-primer/issues/39) ∙ [tiếng Việt](https://github.com/donnemartin/system-design-primer/issues/127) ∙ [Français](https://github.com/donnemartin/system-design-primer/issues/250) | [Add Translation](https://github.com/donnemartin/system-design-primer/issues/28)*
*[English](README.md) ∙ [日本語](README-ja.md) ∙ [简体中文](README-zh-Hans.md) ∙ [繁體中文](README-zh-TW.md) | [العَرَبِيَّة‎](README-ar.md) ∙ [বাংলা](https://github.com/donnemartin/system-design-primer/issues/220) ∙ [Português do Brasil](https://github.com/donnemartin/system-design-primer/issues/40) ∙ [Deutsch](https://github.com/donnemartin/system-design-primer/issues/186) ∙ [ελληνικά](https://github.com/donnemartin/system-design-primer/issues/130) ∙ [עברית](https://github.com/donnemartin/system-design-primer/issues/272) ∙ [Italiano](https://github.com/donnemartin/system-design-primer/issues/104) ∙ [한국어](https://github.com/donnemartin/system-design-primer/issues/102) ∙ [فارسی](https://github.com/donnemartin/system-design-primer/issues/110) ∙ [Polski](https://github.com/donnemartin/system-design-primer/issues/68) ∙ [русский язык](https://github.com/donnemartin/system-design-primer/issues/87) ∙ [Español](https://github.com/donnemartin/system-design-primer/issues/136) ∙ [ภาษาไทย](https://github.com/donnemartin/system-design-primer/issues/187) ∙ [Türkçe](https://github.com/donnemartin/system-design-primer/issues/39) ∙ [tiếng Việt](https://github.com/donnemartin/system-design-primer/issues/127) ∙ [Français](https://github.com/donnemartin/system-design-primer/issues/250) | [Add Translation](https://github.com/donnemartin/system-design-primer/issues/28)*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

format changes should be reverted

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand the problem here

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be fine, the only change is the arabic link to point to the Readme-ar.md instead of the issue.

@xx7Ahmed7xx
Copy link
Author

Hey Ahmad, Thanks for posting and reviewing..
I agree with most of points mentioned by you and really appericated taking time into it, However the only thing that I feel irrevelant is saying "unnecessary translates" whenever possible the learner should know the arabic match due to many reasons out of topic, and I will check tomorrow rest of the changes and fix them.
I will point eachone.
Greetings!

@xx7Ahmed7xx
Copy link
Author

I made the most needed ones and the repository is ready for merge.

@xx7Ahmed7xx
Copy link
Author

Added The arabic Translation.

@xx7Ahmed7xx
Copy link
Author

Can someone merge the pull ? @donnemartin

@xx7Ahmed7xx
Copy link
Author

Edited the broken link to a working link inside the arabic translation file.

Copy link
Author

@xx7Ahmed7xx xx7Ahmed7xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes.

Copy link
Author

@xx7Ahmed7xx xx7Ahmed7xx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes requested has been fixed.

@xx7Ahmed7xx
Copy link
Author

@donnemartin can we merge ?

@xx7Ahmed7xx
Copy link
Author

@donnemartin

@xx7Ahmed7xx
Copy link
Author

@donnemartin @aymns
I'm trying to work on this but no one is responding.. ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants