-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a Dockerfile to run gitsome in a Docker container #99
Conversation
Current coverage is 95.20% (diff: 100%)@@ master #99 diff @@
==========================================
Files 34 34
Lines 2105 2105
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2004 2004
Misses 101 101
Partials 0 0
|
Hi @l0rd, thanks for the pull request! Could you also update the README with Docker install instructions?
|
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
@donnemartin I've done what you've asked. Note that I'm using my Docker hub repository in the doc: $ docker run -ti --rm mariolet/gitsome You will probably want to use another Docker hub repository with an automated build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking great, just a few minor comments. Thanks again for hooking this up!
@@ -121,7 +121,8 @@ For no color, set the value(s) to `None`. `white` can appear as light gray on s | |||
|
|||
## Available Platforms | |||
|
|||
`gitsome` is available for Mac, Linux, Unix, and [Windows](#windows-support). | |||
`gitsome` is available for Mac, Linux, Unix, [Windows](#windows-support) and | |||
[Docker](#running-as-docker-container). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we combine lines 124 and 125 into a single line?
@@ -176,6 +177,7 @@ For no color, set the value(s) to `None`. `white` can appear as light gray on s | |||
* [Installation](#installation) | |||
* [Pip Installation](#pip-installation) | |||
* [Virtual Environment Installation](#virtual-environment-installation) | |||
* [Running as Docker container](#running-as-docker-container) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we capitalize "Container"?
@@ -548,6 +550,34 @@ To deactivate the `gitsome` `virtualenv`, run: | |||
|
|||
$ deactivate | |||
|
|||
### Running as Docker Container |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "Running as a Docker Container"? If we make this change, please update line 180
@l0rd Thank you! |
Fix review comments in #99.
Fix review comments in #99.
Signed-off-by: Mario Loriedo mario.loriedo@gmail.com