Refactor conversion of None to empty introduced in #49 and #40 #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.18% (diff: 100%)@@ master #93 diff @@
==========================================
Files 34 34
Lines 2094 2098 +4
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 1993 1997 +4
Misses 101 101
Partials 0 0
|
|
Hi @jashgala, thanks for the PR! I hope to review it this week. |
donnemartin
requested changes
Dec 2, 2016
| @@ -184,3 +184,14 @@ def _safe_split(self, text): | |||
| return words | |||
| except: | |||
| return text | |||
|
|
|||
| def sanitize_if_none(self, text): | |||
| """Sanitizes text to ensure it is not None | |||
There was a problem hiding this comment.
Could you PEP-257-ify this docstring to the following?
Sanitize text to ensure it is not None.
| """Sanitizes text to ensure it is not None | ||
|
|
||
| :type text:str | ||
| :param text: String to sanitize |
There was a problem hiding this comment.
Also, a period here.
String to sanitize.
|
@jashgala sorry for the late review, thanks again for the PR. I've requested some minor tweaks to the docstring. Also, could you resolve the conflicts? Thanks! |
|
Continued in #100 (Changed target branch) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handled refactoring discussed in Issue #52.
Moved check for None to TextUtils and updated the github.py functions to use that instead of directly checking in the function itself.