Fix #49: create-repo error if no description specified

[Manu343726]

This fixes #49 with the same solution that fixed #40 as you suggested.

I've also checked another functions of GitHub class searching for bugs like this, but didn't found something else left. Since seems that python API uses None as placeholder for optional arguments, I would write a wrapper around click.secho() to handle Nones as empty strings so this bug would never arise again.

[codecov-io]

Current coverage is 95.50%

Merging #50 into master will increase coverage by <.01%

@@             master        #50   diff @@
==========================================
  Files            34         34          
  Lines          2068       2069     +1   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits           1975       1976     +1   
  Misses           93         93          
  Partials          0          0          

Powered by Codecov. Last updated by 64d3d33...287a1d3

[donnemartin]

Thanks for the PR and for checking other areas.

I would write a wrapper around click.secho() to handle Nones as empty strings so this bug would never arise again.

I'm not sure I follow...click.secho takes a text param, and the text param is constructed in create_issue or create_repo before it is passed onto click.secho.

I'll submit a follow-up to update the tests based on the recent bug fixes.

[donnemartin]

Tests update: #51

[Manu343726]

What I mean is that if you pass these arguments to a string "sanitization" function first, you don't have to worry about this None -> string bugs anymore.

[donnemartin]

Ah, sorry I misunderstood. Yes I agree. I think the existing TextUtils might be a good place for that.

[donnemartin]

Filed an issue to track the refactor: #52.

Thanks again!

[Manu343726]

You're welcome