Add test scaffold for Deno #456
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Haven't had bandwidth or a reason to work on Deno support for a while, going to close this but if anyone needs Deno support and wants to contribute here please reach out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress, attempting to get the unit tests (or most of them, at least) to run in Deno. I'm creating a shim for the 'tape' dependency, based on Deno's built-in
Deno.testand assertions. This still gives tap-compatible output, which is nice.deno test --import-map test/deno-import-map.json --no-check packages/core/test/Currently any tests relying on NodeIO fails (a lot of tests); this depends on #380. Ideally the unit tests (excluding NodeIO-specific tests) would use a shared utility to get an I/O instance appropriate for the current test environment.