Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parent/child validation regression #1026

Merged
merged 2 commits into from
Jul 14, 2023
Merged

Fix parent/child validation regression #1026

merged 2 commits into from
Jul 14, 2023

Conversation

donmccurdy
Copy link
Owner

Requirements:

  1. Nodes MAY be root children of multiple Scenes
  2. Nodes MUST NOT be children of >1 Node
  3. Nodes MUST NOT be children of both Nodes and Scenes

@donmccurdy donmccurdy added bug Something isn't working package:core labels Jul 14, 2023
@donmccurdy donmccurdy added this to the v3.4 milestone Jul 14, 2023
@donmccurdy donmccurdy mentioned this pull request Jul 14, 2023
Merged
@donmccurdy donmccurdy merged commit fe60959 into main Jul 14, 2023
5 checks passed
@donmccurdy donmccurdy deleted the hotfix/move-root-node branch July 14, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working package:core
Projects
None yet
Milestone
v3.4
Development

Successfully merging this pull request may close these issues.

Breaking change to addChild between 3.0 and 3.1
1 participant
@donmccurdy