-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Deno] Error While Installing /functions Package #834
Comments
Unfortunately there are a number of obstacles. I'd like to support Deno, but in practice it's pretty complicated. Certain decisions by the TypeScript team, and the difficulty of running the unit tests in multiple environments, have been obstacles. See #457. I'll take a look at the ndarray issues, those may be simple enough to fix: But I'm not sure Deno will 'just work' even with those issues resolved. If you'd be up for doing some more investigation here, that'd be very welcome -- thanks! |
Possible fix, at least for the ndarray-related part of the problem: |
Understood, if #835 doesn't fix this then I'll see if I can look into it some more. Thanks for the quick response anyway! |
Published v3.0.4 — Haven't tested thoroughly, but this much seems to work: import { Document, DenoIO } from 'https://esm.sh/@gltf-transform/core';
import { KHRONOS_EXTENSIONS } from 'https://esm.sh/@gltf-transform/extensions';
import { dedup } from 'https://esm.sh/@gltf-transform/functions';
const io = new DenoIO().registerExtensions(KHRONOS_EXTENSIONS);
const document = new Document();
console.log(document); |
Works for me as well! Thanks for addressing. |
Describe the bug
When running a Deno script that imports
@gltf-transform/functions
viahttps://esm.sh/@gltf-transform/functions
, a500
HTTP response is returned when it tries to installhttps://esm.sh/v107/ndarray-lanczos@0.2.0/deno/ndarray-lanczos.js
.The error is:
I suspect this is related to the build configuration of donmccurdy/ndarray-lanczos.
Steps To Reproduce
error-test.js
with this as the only line:import * as f from 'https://esm.sh/@gltf-transform/functions'
deno run --allow-net error-test.js
Expected behavior
An error-free install and script execution.
Versions:
Deno
: 1.25.0gltf-transform
: 3.0.3The text was updated successfully, but these errors were encountered: