Skip to content

Commit

Permalink
Updated KHR_materials_iridescence camelCase convention (#570)
Browse files Browse the repository at this point in the history
  • Loading branch information
donmccurdy authored Apr 22, 2022
1 parent 372fad5 commit 8120ed6
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ const NAME = KHR_MATERIALS_IRIDESCENCE;
interface IridescenceDef {
iridescenceFactor: number;
iridescenceTexture: GLTF.ITextureInfo;
iridescenceIOR: number;
iridescenceIor: number;
iridescenceThicknessMinimum: number;
iridescenceThicknessMaximum: number;
iridescenceThicknessTexture: GLTF.ITextureInfo;
Expand Down Expand Up @@ -76,8 +76,8 @@ export class MaterialsIridescence extends Extension {
if (iridescenceDef.iridescenceFactor !== undefined) {
iridescence.setIridescenceFactor(iridescenceDef.iridescenceFactor);
}
if (iridescenceDef.iridescenceIOR !== undefined) {
iridescence.setIridescenceIOR(iridescenceDef.iridescenceIOR);
if (iridescenceDef.iridescenceIor !== undefined) {
iridescence.setIridescenceIOR(iridescenceDef.iridescenceIor);
}
if (iridescenceDef.iridescenceThicknessMinimum !== undefined) {
iridescence.setIridescenceThicknessMinimum(iridescenceDef.iridescenceThicknessMinimum);
Expand Down Expand Up @@ -128,7 +128,7 @@ export class MaterialsIridescence extends Extension {
iridescenceDef.iridescenceFactor = iridescence.getIridescenceFactor();
}
if (iridescence.getIridescenceIOR() !== 1.3) {
iridescenceDef.iridescenceIOR = iridescence.getIridescenceIOR();
iridescenceDef.iridescenceIor = iridescence.getIridescenceIOR();
}
if (iridescence.getIridescenceThicknessMinimum() !== 100) {
iridescenceDef.iridescenceThicknessMinimum = iridescence.getIridescenceThicknessMinimum();
Expand Down
2 changes: 1 addition & 1 deletion packages/extensions/test/materials-iridescence.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ test('@gltf-transform/extensions::materials-iridescence', async (t) => {
{
KHR_materials_iridescence: {
iridescenceFactor: 0.9,
iridescenceIOR: 1.5,
iridescenceIor: 1.5,
iridescenceThicknessMinimum: 50,
iridescenceThicknessMaximum: 500,
iridescenceTexture: { index: 0 },
Expand Down

0 comments on commit 8120ed6

Please sign in to comment.