forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[SPARK-44906][K8S] Make
Kubernetes[Driver|Executor]Conf.annotations
…
… substitute annotations instead of feature steps ### What changes were proposed in this pull request? Move `Utils. SubstituteAppNExecIds` logic into `KubernetesConf.annotations` as the default logic, ### Why are the changes needed? Easy for users to reuse, rather than to rewrite it again at the same logic. When user write custom feature step and using annotations, before this pr, they should call `Utils. SubstituteAppNExecIds` once. ### Does this PR introduce _any_ user-facing change? Yes, but no sense for user to use annotations. ### How was this patch tested? Add unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#42600 from zwangsheng/SPARK-44906. Lead-authored-by: zwangsheng <2213335496@qq.com> Co-authored-by: Kent Yao <yao@apache.org> Signed-off-by: Dongjoon Hyun <dhyun@apple.com>
- Loading branch information
1 parent
2d0a0a0
commit 2a3aec1
Showing
4 changed files
with
15 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters