Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#59 Improve current export images (png and pdf) #1141

Merged
merged 4 commits into from
Nov 13, 2024
Merged

#59 Improve current export images (png and pdf) #1141

merged 4 commits into from
Nov 13, 2024

Conversation

ntran18
Copy link
Collaborator

@ntran18 ntran18 commented Nov 6, 2024 •
edited
Loading

Improved for #59

  • Change the background color from black to white for PNG export
  • Fixing the exportToPDF so the image doesn't too scale on width or height

@ntran18 ntran18 changed the title Improve current export images (png and pdf) #59 Improve current export images (png and pdf) Nov 6, 2024
dondi
dondi approved these changes Nov 6, 2024
View reviewed changes
Copy link
Owner

@dondi dondi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice—you are gaining some expertise in both SVG and PDF here!

@dondi
Copy link
Owner

dondi commented Nov 6, 2024

I’ll wait to merge this for now, in case there are dependencies on the earlier PRs

@dondi dondi merged commit 4f0adaf into beta Nov 13, 2024
@dondi dondi deleted the maika-59 branch November 13, 2024 17:17
@ntran18 ntran18 mentioned this pull request Nov 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dondi dondi dondi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntran18 @dondi