Skip to content

Commit

Permalink
Made tvm url optional (ydb-platform#1591)
Browse files Browse the repository at this point in the history
* Made tvm url optional

* Python codestyle fix

* Changed validation accordingly
  • Loading branch information
domwst committed Feb 7, 2024
1 parent fce7307 commit 4fba45b
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion ydb/core/protos/config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -1607,7 +1607,7 @@ message TTracingConfig {
message TBackendConfig {
message TAuthConfig {
message TTvmAuth {
required string Url = 1;
optional string Url = 1;

required uint32 SelfTvmId = 2;
required uint32 TracingTvmId = 3;
Expand Down
1 change: 0 additions & 1 deletion ydb/tools/cfg/static.py
Original file line number Diff line number Diff line change
Expand Up @@ -1133,7 +1133,6 @@ def get_sampling_scope(sampling):
sampling_scope_pb.MaxBurst = sampling['max_burst']
return sampling_scope_pb


def get_external_throttling(throttling):
throttling_scope_pb = config_pb2.TTracingConfig.TExternalThrottlingScope()
selectors = throttling.get("scope")
Expand Down
2 changes: 1 addition & 1 deletion ydb/tools/cfg/validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@
secret_file=dict(type="string"),
secret_environment_variable=dict(type="string"),
),
required=["url", "self_tvm_id", "tracing_tvm_id"],
required=["self_tvm_id", "tracing_tvm_id"],
)
),
required=["tvm"],
Expand Down

0 comments on commit 4fba45b

Please sign in to comment.