Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added method to check if parent project exists for module #80

Merged
merged 3 commits into from
May 30, 2021

Conversation

FelixTheodor
Copy link
Contributor

closes #72

i added a method to check if the parent of a module exists before creating it.
the create-command now returns an error if it does not exist.

Copy link
Owner

@dominikbraun dominikbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion 😄

core/project.go Outdated Show resolved Hide resolved
core/project.go Outdated Show resolved Hide resolved
@FelixTheodor
Copy link
Contributor Author

Thanks for the feedback, added the changes in a new commit :)

Copy link
Owner

@dominikbraun dominikbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@dominikbraun dominikbraun merged commit 530a420 into dominikbraun:main May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent users from creating modules for non-existent projects
2 participants