This repository has been archived by the owner on Apr 2, 2019. It is now read-only.
Resolving maximum call stack size exceeded issue #28
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for #26 which seems to occur when too much data is queued up at once and then return using the recursive call. We saw the error coming up when reading files with millions of lines and when pulling thousands of results from a DB. I updated the code to follow the same logic as before, but use a loop instead to avoid recursion issues.
I read through another thread and saw this was discussed as a potential solution, the update passed all unit testing and worked well when I tested against a few additional stream examples. Let me know your thoughts.