Explicitly specify PNG as the output format #33
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when rendering, svg2png lets PhantomJS determine the output format. According to the documentation, PhantomJS uses the output file extension to choose the correct output format. However, this logic breaks down when the output file has an unusual extension or no extension at all. This pull request forces the output extension to always be PNG. The downside of this is that users will no longer be able to use this tool to generate GIFs, JPEGs, or PDFs from SVGs. My reasoning is that since this project is called svg2png that is an appropriate restriction, but as the owner, what are your thoughts regarding this?