Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix generation when [DefaultValue]'s type differs #2895

Merged
merged 4 commits into from
May 21, 2024
Merged

Fix generation when [DefaultValue]'s type differs #2895

merged 4 commits into from
May 21, 2024

Commits on May 19, 2024

  1. Fix generation when [DefaultValue]'s type differs 

    Fix SwaggerGeneratorException if the type of a `[DefaultValue]` does not match the type of the property when using System.Text.Json for serialization.
Resolves domaindrivendev#2885.
    @martincostello
    martincostello committed May 19, 2024
    Configuration menu
    Copy the full SHA
    cb030a7 View commit details
    Browse the repository at this point in the history

  2. Fix generation for nullable enums 

    - Fix schema generation of default values for nullable enums with System.Text.Json.
- Resolve some IDE refactoring suggestions.
- Render the response if an integration test fails.
Resolves domaindrivendev#2904.
    @martincostello
    martincostello committed May 19, 2024
    Configuration menu
    Copy the full SHA
    5e22cd0 View commit details
    Browse the repository at this point in the history

  3. Unify implementations 

    Use the same implementation for coercing the default value to the correct type for both `[DefaultValue]` and default method parameters.
    @martincostello
    martincostello committed May 19, 2024
    Configuration menu
    Copy the full SHA
    b10358c View commit details
    Browse the repository at this point in the history

  4. Fix null check 

    Fix null not being checked for after refactor.
    @martincostello
    martincostello committed May 19, 2024
    Configuration menu
    Copy the full SHA
    dd47198 View commit details
    Browse the repository at this point in the history