-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove reflection-based JSON serialization from SwaggerUIMiddleware #2724
Remove reflection-based JSON serialization from SwaggerUIMiddleware #2724
Conversation
Can I ask a question, I saw the bug and I reviewed the PR, I know this is not my business, but I just want to wonder, if possible, why this PR is not merged yet. |
Hi everyone. @VMelnalksnis, @bdukes, @domaindrivendev, @captainsafia, @eslamisepehr can I ask whether you will have time soon to fix the issues with the workflow and merge this PR? It would be great if you would manage to do this because this will help a lot of people. Thanks! |
I see that CI is failing because .NET 6 SDK is missing: |
Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI. We'd also appreciate tests for this scenario to prevent regressions. |
Ok, I'll check out the current tests and see where I can add them. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2724 +/- ##
==========================================
+ Coverage 91.69% 91.71% +0.01%
==========================================
Files 91 91
Lines 3022 3029 +7
Branches 519 519
==========================================
+ Hits 2771 2778 +7
Misses 251 251
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I see that the PR already adds |
Fixes #2550