Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Stream and PipeReader content types correctly #2526

Conversation

martincostello
Copy link
Collaborator

  • Do not generate schema models for Stream and PipeReader.
  • Only allocate the array once, rather than on every call.
  • Fix warning by removing unused parameter from private method.

/cc @captainsafia

Relates to item 3 in dotnet/aspnetcore#44677.

Fix warning by removing unused parameter from private method.
Only allocate the array once, rather than on every call.
Do not generate schema models for `Stream` and `PipeReader`.
See dotnet/aspnetcore#44677 (comment).
@martincostello
Copy link
Collaborator Author

I'm declaring bankruptcy on this PR. Will come back to it maybe if/when this project shows some signs of life in the future.

@martincostello martincostello deleted the handle-stream-and-pipereader branch January 30, 2024 17:08
@martincostello martincostello restored the handle-stream-and-pipereader branch April 13, 2024 08:08
@martincostello
Copy link
Collaborator Author

Moved to #2784.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant