Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add startup callback to settings for httpbeast #318

Closed
wants to merge 1 commit into from
Closed

Add startup callback to settings for httpbeast #318

wants to merge 1 commit into from

Conversation

ThomasTJdev
Copy link
Contributor

Hi Dom,

A follow-up PR from the httpbeast PR dom96/httpbeast#89 :)

  • This PR implements the startup proc in Jester' settings, which then is passed on to httpbeast. The startup proc will run in each httpbeast-thread at initialization.
  • As is, this PR only implements the startup proc to be used, when jester is running with httpbeast.
  • The concept for "only allowing" with httpbeast follows the previous numThreads implementation.

Would this be a possible PR? Or are there any changes you would like to see?

@dom96
Copy link
Owner

dom96 commented Aug 8, 2023

Weirdly (and this is unrelated to this PR) it seems @iffy's github action is installing the stable Nim, rather than the one defined by nimversion.

@iffy
Copy link
Contributor

iffy commented Aug 9, 2023

install-nim is expecting a variable named version not nimversion

Warning: Unexpected input(s) 'nimversion', valid inputs are ['version']

@iffy
Copy link
Contributor

iffy commented Aug 9, 2023

Change

nimversion: ${{ matrix.nimversion }}

to

          version: ${{ matrix.nimversion }}

@bung87 bung87 closed this by deleting the head repository Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants