Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use main thread to serve requests #62

Merged
merged 1 commit into from
Oct 29, 2021
Merged

Use main thread to serve requests #62

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/httpbeast.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,17 +491,15 @@ proc run*(onRequest: OnRequest, settings: Settings) =
echo("Starting ", numThreads, " threads")
if numThreads > 1:
when compileOption("threads"):
var threads = newSeq[Thread[(OnRequest, Settings)]](numThreads)
for i in 0 ..< numThreads:
var threads = newSeq[Thread[(OnRequest, Settings)]](numThreads - 1)
for t in threads.mitems():
createThread[(OnRequest, Settings)](
threads[i], eventLoop, (onRequest, settings)
t, eventLoop, (onRequest, settings)
)
echo("Listening on port ", settings.port) # This line is used in the tester to signal readiness.
joinThreads(threads)
else:
assert false
else:
eventLoop((onRequest, settings))
eventLoop((onRequest, settings))

proc run*(onRequest: OnRequest) {.inline.} =
## Starts the HTTP server with default settings. Calls `onRequest` for each
Expand Down