Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires "asynctools" now that asynctools was updated #49

Merged

Conversation

timotheecour
Copy link
Contributor

httpbeast.nimble Outdated Show resolved Hide resolved
@timotheecour
Copy link
Contributor Author

timotheecour commented Jun 29, 2021

@Araq could you please tag a release for asynctools to avoid having to do this: #49 (comment) ?

in dom's own words (nim-lang/nimble#890 (comment)):

Specifying a concrete version in a Nimble file has always been a bad idea and largely discouraged. I think that once lock files are merged into Nimble that we should look into disallowing concrete versions in "requires" completely (without lock files this is the only way you can hope to get reproducible builds).

@dom96
Copy link
Owner

dom96 commented Jun 29, 2021

A tagged version won't help much here. I want reproducible builds, but yes, this does run the risk that people's projects will clash with the asynctools dep :/

Maybe a better way is to just run nimble install asynctools in a "before test: ..."

@dom96 dom96 merged commit 16a5bec into dom96:master Jul 1, 2021
@timotheecour timotheecour deleted the pr_httpbeast_update_requires_asynctools branch July 1, 2021 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants