Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proto: Move .proto files to dolthub/vt subdirectory and package name. #166

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

reltuk
Copy link

@reltuk reltuk commented May 31, 2022

Removes global proto registry conflict with vitessio/vitess, as per #155.

Removes global proto registry conflict with vitessio/vitess, as per #155.
Copy link

@ryanpbrewster ryanpbrewster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me :)

@ryanpbrewster
Copy link

ryanpbrewster commented Jun 2, 2022

Do you have an estimate of when this PR will make it's way upstream into the go-mysql-server repo?

EDIT: oh my, did this already happen in dolthub/go-mysql-server#1035? Very quick turnaround.

@reltuk
Copy link
Author

reltuk commented Jun 2, 2022

Do you have an estimate of when this PR will make it's way upstream into the go-mysql-server repo?

EDIT: oh my, did this already happen in dolthub/go-mysql-server#1035? Very quick turnaround.

Glad this worked out :). Thanks again for the report and very credible and near-at-hand solution proposal :).

@Hydrocharged Hydrocharged deleted the aaron/proto-to-dolthub-vt-subdir branch October 13, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants