Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Point method to actually print string #956

Merged
merged 3 commits into from
Apr 19, 2022
Merged

Fixing Point method to actually print string #956

merged 3 commits into from
Apr 19, 2022

Conversation

jycor
Copy link
Contributor

@jycor jycor commented Apr 18, 2022

Fix for: dolthub/dolt#3228
Allows the use of point(), linestring(), and polygon() for default values for columns of type point, linestring, polygon, and geometry.

jennifersp
jennifersp approved these changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@jennifersp jennifersp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jycor jycor merged commit 98ba735 into main Apr 19, 2022
@Hydrocharged Hydrocharged deleted the james/point-string branch October 13, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennifersp jennifersp jennifersp approved these changes

@VinaiRachakonda VinaiRachakonda Awaiting requested review from VinaiRachakonda

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jycor @jennifersp