RetroAchievements - Patch Allowlist Unit Test #12913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LillyJadeKatrin
force-pushed
the
retroachievements-allowlist-test
branch
24 times, most recently
from
36f8a40 to
2955e73
Compare
|
Before you start rewriting the entire test system here, have you considered just embedding the allowed patch list in the executable instead of loading them at runtime? |
LillyJadeKatrin
force-pushed
the
retroachievements-allowlist-test
branch
5 times, most recently
from
0ecec9a to
d00984c
Compare
LillyJadeKatrin
force-pushed
the
retroachievements-allowlist-test
branch
2 times, most recently
from
c2cf259 to
96c9510
Compare
Prototype of a system to whitelist known game patches that are allowed to be used while RetroAchievements Hardcore mode is active. ApprovedInis.txt contains known hashes for the ini files as they appear in the repo, and can be compared to the local versions of these files to ensure they have not been edited locally by the player. ApprovedInis.txt is hashed and verified similarly first, with its hash residing as a const string within AchievementManager.h, ensuring ApprovedInis and the hashes within cannot be modified without editing Dolphin's source code and recompiling completely.
LillyJadeKatrin
force-pushed
the
retroachievements-allowlist-test
branch
13 times, most recently
from
5779f5c to
067fd40
Compare
AdmiralCurtiss
force-pushed
the
retroachievements-allowlist-test
branch
3 times, most recently
from
6afe567 to
d039418
Compare
AdmiralCurtiss
force-pushed
the
retroachievements-allowlist-test
branch
2 times, most recently
from
c243e47 to
05698e5
Compare
This unit test compares ApprovedInis.json with the contents of the GameSettings folder to verify that every patch marked allowed for use with RetroAchievements has a hash in ApprovedInis.json. If not, that hash is reported in the test logs so that the hash may be updated more easily.
AdmiralCurtiss
force-pushed
the
retroachievements-allowlist-test
branch
from
05698e5 to
ae87bf9
Compare
SternXD
pushed a commit
to SternXD/dolphin-uwp
that referenced
this pull request
Feb 7, 2025
…ements-allowlist-test RetroAchievements - Patch Allowlist Unit Test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This unit test compares ApprovedInis.json with the contents of the GameSettings folder to verify that every patch marked allowed for use with RetroAchievements has a hash in ApprovedInis.json. If not, that hash is reported in the test logs so that the hash may be updated more easily.