Merge pull request #128 from dolittle:batched-event-handler

Batched-event-handler
dolittle · Oct 5, 2022 · 17d44ab · 17d44ab
2 parents 182f50b + 709c79d
commit 17d44ab
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 13 deletions.
diff --git a/Source/Runtime/Events.Processing/EventHandlers.proto b/Source/Runtime/Events.Processing/EventHandlers.proto
@@ -23,12 +23,13 @@ message EventHandlerRegistrationRequest {
     repeated artifacts.Artifact eventTypes = 4;
     bool partitioned = 5;
     optional string alias = 6;
-    // bool batched = 7; // Whether the processor is batched or not. TODO: We could drop this and have a flag in the Runtime that gets turned on for batching when using this version of the contracts or greater
+    bool batched = 7; // Whether the processor is batched or not.
 }
 
 message EventHandlerResponse {
     services.ReverseCallResponseContext callContext = 1;
     ProcessorFailure failure = 2; // If not set/empty - no failure
+    uint32 failedEventBatchPosition = 3; // The zero-indexed batch position of the event in the batch that failed.
 }
 
 message EventHandlerClientToRuntimeMessage {

diff --git a/Source/Runtime/Events.Processing/Processors.proto b/Source/Runtime/Events.Processing/Processors.proto
@@ -19,7 +19,6 @@ message ProcessorFailure {
     string reason = 1;
     bool retry = 2;
     google.protobuf.Duration retryTimeout = 3;
-    StreamEventMetadata eventMetadata = 4; // The metadata of the event that failed
 }
 
 message RetryProcessingState {

diff --git a/Source/Runtime/Events.Processing/StreamEvent.proto b/Source/Runtime/Events.Processing/StreamEvent.proto
@@ -13,15 +13,7 @@ option go_package = "go.dolittle.io/contracts/runtime/events/processing";
 
 message StreamEvent {
     events.CommittedEvent event = 1;
-    string partitionId = 2 [deprecated = true]; // Replaced by metadata
-    protobuf.Uuid scopeId = 3 [deprecated = true]; // Replaced by metadata
-    bool partitioned = 4 [deprecated = true]; // Replaced by metadata
-    StreamEventMetadata metadata = 5; // The metadata of the stream event
-}
-
-message StreamEventMetadata {
-    string partitionId = 1; // The partition id of the event
-    protobuf.Uuid scopeId = 2; // The scope id of the event
-    bool partitioned = 3; // Whether the stream is partitioned or not
-    uint64 streamPosition = 4; // The stream position of the event
+    string partitionId = 2;
+    protobuf.Uuid scopeId = 3;
+    bool partitioned = 4;
 }