Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Firedrake constants change #98

Merged
merged 10 commits into from
Jun 14, 2023
Merged

Firedrake constants change #98

merged 10 commits into from
Jun 14, 2023

Conversation

JDBetteridge
Copy link
Contributor

No description provided.

@JDBetteridge JDBetteridge marked this pull request as ready for review June 7, 2023 13:27
@JDBetteridge JDBetteridge mentioned this pull request Jun 7, 2023
Merged
17 tasks
dham
dham requested changes Jun 7, 2023
View reviewed changes
dolfin_adjoint_common/compat.py Outdated Show resolved Hide resolved
JDBetteridge and others added 2 commits June 8, 2023 11:32
@JDBetteridge @dham
Docstring
d435ce3 
Co-authored-by: David A. Ham <david.ham@imperial.ac.uk>
@JDBetteridge
Turns out Taylor test already handles conv_mixed
c6b1c1a
connorjward
connorjward reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me but I don't want to be the one to approve this.

@dham dham merged commit 66567ba into master Jun 14, 2023
@dham dham deleted the connorjward/constants-away branch June 14, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjward connorjward connorjward left review comments

@dham dham dham requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JDBetteridge @dham @connorjward