-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Allow for an asymmetric public key encryption #81
Merged
josegonzalez
merged 5 commits into
dokku:master
from
mykolasolodukha:feature/use-gpg-public-key-encryption
Mar 28, 2024
Merged
✨ Allow for an asymmetric public key encryption #81
josegonzalez
merged 5 commits into
dokku:master
from
mykolasolodukha:feature/use-gpg-public-key-encryption
Mar 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mind resolving the |
mykolasolodukha
force-pushed
the
feature/use-gpg-public-key-encryption
branch
from
March 24, 2024 18:17
4b45089
to
c8dacd9
Compare
So that the default one will be used. Important for GCP Storage buckets that have different STORAGE_CLASS IDs, hence incompatible with `aws-cli`.
mykolasolodukha
force-pushed
the
feature/use-gpg-public-key-encryption
branch
from
March 24, 2024 18:17
c8dacd9
to
6ea7ec6
Compare
@josegonzalez feel free to push directly into the branch👌 It might take me a while to figure out what's wrong with the |
@josegonzalez I think I've got this. |
@josegonzalez any chance we can merge this? |
This was merged and released. |
mykolasolodukha
added a commit
to mykolasolodukha/dokku-postgres
that referenced
this pull request
Apr 28, 2024
First introduced in dokku/docker-s3backup#81.
2 tasks
mykolasolodukha
added a commit
to mykolasolodukha/dokku-postgres
that referenced
this pull request
Apr 28, 2024
First introduced in dokku/docker-s3backup#81.
mykolasolodukha
added a commit
to mykolasolodukha/dokku-postgres
that referenced
this pull request
Jun 9, 2024
First introduced in dokku/docker-s3backup#81.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
ENCRYPT_WITH_PUBLIC_KEY_ID
env parameter to encrypt the backups with the User's GPG public key.shfmt
formatting.Why?
s3backup
service configs and the access to the S3 storage. When the said actor gains write access, it's still a game over for whoever's trying to protect that data.How to test?
gpg --send-keys --keyserver keyserver.ubuntu.com $MY_PUBLIC_KEY_ID
docker run -it \ -e AWS_ACCESS_KEY_ID=ID \ -e AWS_SECRET_ACCESS_KEY=KEY \ -e BUCKET_NAME=backups \ -e BACKUP_NAME=backup \ -e ENCRYPT_WITH_PUBLIC_KEY_ID=$MY_PUBLIC_KEY_ID \ -v /path/to/backup:/backup dokku/s3backup
Anything else?
-e KEYSERVER=$YOUR_KEYSERVER
to thedocker run
command.