refactor(katana): store genesis in ChainSpec as its JSON repr
#2871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kariy
force-pushed
the
katana/chainspec
branch
from
425b2a3 to
c31175e
Compare
kariy
force-pushed
the
katana/chainspec-genesis
branch
from
64dbf2c to
2aeeafd
Compare
kariy
force-pushed
the
katana/chainspec-genesis
branch
from
02f0d09 to
b02659d
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## katana/chainspec #2871 +/- ##
====================================================
+ Coverage 55.74% 55.85% +0.10%
====================================================
Files 446 447 +1
Lines 57818 57911 +93
====================================================
+ Hits 32233 32345 +112
+ Misses 25585 25566 -19 ☔ View full report in Codecov by Sentry. |
kariy
added a commit
that referenced
this pull request
Jan 8, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 10, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 11, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 14, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 15, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 16, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 16, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 18, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 19, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 21, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 21, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 21, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
kariy
added a commit
that referenced
this pull request
Jan 23, 2025
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using `--genesis`. The JSON repr is a more user facing format compared to its internal counterpart (ie `Genesis`).
This was referenced Jan 24, 2025
This was referenced Jan 24, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow specifying the genesis file in the chain spec file in its JSON format. Basically, in the same format as if when the genesis file is passed using
--genesis. The JSON repr is a more user facing format compared to its internal counterpart (ieGenesis).