Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break on empty events when loading from remote #2376

Merged
merged 2 commits into from
Sep 1, 2024

make sure to insert first before break on missing token

70ecd82
Select commit
Loading
Failed to load commit list.
Merged

Break on empty events when loading from remote #2376

make sure to insert first before break on missing token
70ecd82
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 1, 2024 in 1s

67.85% (+0.12%) compared to f62acf2

View this Pull Request on Codecov

67.85% (+0.12%) compared to f62acf2

Details

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.85%. Comparing base (f62acf2) to head (70ecd82).

Files with missing lines Patch % Lines
crates/dojo-world/src/manifest/mod.rs 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2376      +/-   ##
==========================================
+ Coverage   67.72%   67.85%   +0.12%     
==========================================
  Files         359      359              
  Lines       47034    46959      -75     
==========================================
+ Hits        31854    31862       +8     
+ Misses      15180    15097      -83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.