This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Create Resize Observer Meta #908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylans
suggested changes
Apr 3, 2018
README.md
Outdated
|
|
||
| The resize observer meta uses the latest [`ResizeObserver`](https://wicg.github.io/ResizeObserver/) within your widgets. This is currently supported within `Chrome 64+` and supported via [polyfill](https://github.com/WICG/ResizeObserver/issues/3). | ||
|
|
||
| This allows you to observe resize events at the component level. The `meta` accepts an object of `predicate` functions which receive `ContentRect` dimensions and will be executed when a resize event has occured. The results are made available in your widgets `render` function. This is an incredibly powerful tool for creating responsive layouts. |
README.md
Outdated
| @@ -1176,6 +1176,35 @@ class TestWidget extends WidgetBase<WidgetProperties> { | |||
| } | |||
| ``` | |||
|
|
|||
| #### Resize | |||
|
|
|||
| The resize observer meta uses the latest [`ResizeObserver`](https://wicg.github.io/ResizeObserver/) within your widgets. This is currently supported within `Chrome 64+` and supported via [polyfill](https://github.com/WICG/ResizeObserver/issues/3). | |||
There was a problem hiding this comment.
within your widgets -> within Dojo-based widgets
There was a problem hiding this comment.
This is currently supported within Chrome 64+ and supported via -> Native browser support is currently provided by Chrome 64+ and other Dojo supported browsers work via
dylans
approved these changes
Apr 5, 2018
|
@dylans i'll raise an issue on |
|
@agubler can I get some 👁 on this please? |
matt-gadd
approved these changes
Apr 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Creates
ResizeObservermetawhich can be used to observe component level resize events.Requires a global polyfill to be imported when used outside of chrome 64+.
Example deployed here.
Resolves #618