Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform exists with static build loader, and fix importing default #145

Merged
merged 4 commits into from
May 17, 2019

Conversation

maier49
Copy link
Contributor

@maier49 maier49 commented May 3, 2019

Type: bug

The following has been addressed in the PR:

Description:
This replaces any calls to exists("feature") with true if that feature has been statically specified. It also fixes a bug discovered in the process which is that import { default } from 'somewhere/has' or import { default as whatever } from 'somewhere/has' were not being parsed.

Resolves #68

@maier49 maier49 requested review from agubler and matt-gadd May 3, 2019 20:13
@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #145 into master will increase coverage by 0.18%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #145      +/-   ##
==========================================
+ Coverage    85.6%   85.78%   +0.18%     
==========================================
  Files          40       40              
  Lines        1723     1738      +15     
  Branches      430      441      +11     
==========================================
+ Hits         1475     1491      +16     
+ Misses        248      247       -1
Impacted Files Coverage Δ
src/static-build-loader/loader.ts 100% <100%> (+0.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b54051b...d726ffd. Read the comment docs.

@maier49 maier49 merged commit a92d9bb into dojo:master May 17, 2019
@maier49 maier49 deleted the static-exists branch May 17, 2019 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

static-build-loader should transform exists
2 participants