Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure BTR waits for blocks to complete execution #121

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

agubler
Copy link
Member

@agubler agubler commented Jan 24, 2019

Type: bug

The following has been addressed in the PR:

Description:

Ensure that blocks executing during BTR are completed before capturing the rendered HTML and CSS.

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #121 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   83.89%   83.97%   +0.08%     
==========================================
  Files          38       38              
  Lines        1552     1560       +8     
  Branches      385      385              
==========================================
+ Hits         1302     1310       +8     
  Misses        250      250
Impacted Files Coverage Δ
src/build-time-render/BuildTimeRender.ts 99.13% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1205a91...66dbb42. Read the comment docs.

@agubler agubler merged commit 4701437 into dojo:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants