Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettier
as per the readme code style guidelinesDescription:
The
client
fromwebpack-hot-client
requires using theHotModuleReplacementPlugin
as it deals with more complex scenarios than we support in dojo, such as reloading a single module. For dojo we only support an automatic reload of the page.The
HotModuleReplacementPlugin
also modifies the bundle to support this which is not needed in the dojo build.Adding a custom
client
that only deals with processing messages and either reloading the page or displaying the error overlay (still using the overlay fromwebpack-hot-client
for the moment) and removes the requirement to use theHotModuleReplacementPlugin
meaning that the bundles are not affected and are the same regardless of whether built withwatch/serve
or a standard build.