Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom client for hot reloading #111

Merged
merged 2 commits into from
Jan 8, 2019
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Jan 7, 2019

Type: feature

The following has been addressed in the PR:

Description:

The client from webpack-hot-client requires using the HotModuleReplacementPlugin as it deals with more complex scenarios than we support in dojo, such as reloading a single module. For dojo we only support an automatic reload of the page.

The HotModuleReplacementPlugin also modifies the bundle to support this which is not needed in the dojo build.

Adding a custom client that only deals with processing messages and either reloading the page or displaying the error overlay (still using the overlay from webpack-hot-client for the moment) and removes the requirement to use the HotModuleReplacementPlugin meaning that the bundles are not affected and are the same regardless of whether built with watch/serve or a standard build.

@codecov
Copy link

codecov bot commented Jan 7, 2019

Codecov Report

Merging #111 into master will increase coverage by 0.05%.
The diff coverage is 82.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #111      +/-   ##
==========================================
+ Coverage   84.01%   84.06%   +0.05%     
==========================================
  Files          37       38       +1     
  Lines        1389     1475      +86     
  Branches      372      385      +13     
==========================================
+ Hits         1167     1240      +73     
- Misses        222      235      +13
Impacted Files Coverage Δ
src/bootstrap-plugin/async.js 0% <0%> (ø) ⬆️
src/bootstrap-plugin/sync.js 0% <0%> (ø) ⬆️
src/webpack-hot-client/client.js 84.88% <84.88%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb25b5...35bb6c2. Read the comment docs.

@agubler agubler merged commit 0ee33e5 into dojo:master Jan 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants