This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Add Shims for AbortController and AbortSignal #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add AbortController and AbortSignal shims - add unit tests
nicknisi
force-pushed
the
abort-signal-controller
branch
from
c3408c2 to
9407f68
Compare
rorticus
approved these changes
May 31, 2018
3 tasks
|
Can this be merged? |
|
The tests are failing in IE11. I'll look into why and get it fixed so it can be merged. |
ycabon
reviewed
Jul 13, 2018
tests/unit/AbortController.ts
Outdated
| return new Promise((resolve) => { | ||
| let called = 0; | ||
| const expectedCalls = 2; | ||
| const createEvent = (type: string) => (global.Event ? new Event(type) : ({ type } as Event)); |
There was a problem hiding this comment.
would document.createEvent('Event'); work here in place of the constructor for IE11?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
This adds a shim for
AbortControllerandAbortSignal, which will be used by@dojo/core/requestas discussed in dojo/core#390.