Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating to use helpers from shim #149

Closed
wants to merge 1 commit into from
Closed

Updating to use helpers from shim #149

wants to merge 1 commit into from

Conversation

rorticus
Copy link
Contributor

@rorticus rorticus commented Nov 6, 2017

Updating to use the polyfills / amd loader / tslib from dojo/shim#114

@rorticus rorticus requested a review from kitsonk November 6, 2017 19:38
@rorticus rorticus mentioned this pull request Nov 10, 2017
Merged
3 tasks
@bryanforbes
Copy link
Member

I don't think this change needs to be made for loader:

  • The loader doesn't need a shim
  • Downlevel iteration will create a hard dependency on @dojo/shim or put helpers into the global space

@kitsonk
Copy link
Member

kitsonk commented Nov 14, 2017

I agree with @bryanforbes

@rorticus
Copy link
Contributor Author

Closing as we don't need shims or downlevel iteration

@rorticus rorticus closed this Nov 15, 2017
@dylans dylans added this to the 2017.11 milestone Dec 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kitsonk kitsonk Awaiting requested review from kitsonk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2017.11
Development

Successfully merging this pull request may close these issues.
4 participants
@rorticus @bryanforbes @kitsonk @dylans